Repository navigation
Additional build dependency checks - #739
Merged
Merged
Conversation
Steps must not modify the workspaces of their dependencies. Inside a sandbox this is enforced by mounting them read-only. Outside of a sandbox, nothing prevented a step from inadvertently changing them. With --check-deps, all workspaces that are visible to a step are hashed before and after the step is executed without a sandbox. If any of them changed, the build fails and modified build and package workspaces are invalidated so that they are rebuilt on the next invocation. The check is enabled by default for "bob build" and disabled for "bob dev". It can be configured with the "check_deps" key in default.yaml. Jenkins builds are checked too, unless disabled by the new "jobs.check-deps" extended option. The option is only recorded in the job spec if disabled so that existing jobs are not reconfigured and scheduled again. Fixes BobBuildTool#354.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #739 +/- ##
==========================================
+ Coverage 90.37% 90.40% +0.02%
==========================================
Files 59 59
Lines 17352 17404 +52
==========================================
+ Hits 15682 15734 +52
Misses 1670 1670 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
--check-deps, all workspaces that are visible to a step are hashedbefore and after the step is executed without a sandbox. If any of them
changed, the build fails and modified build and package workspaces are
invalidated so that they are rebuilt on the next invocation.
Fixes #354.